refactor: drop dead query local assignments in resources#21
Open
mokevnin wants to merge 1 commit into
Open
Conversation
Five resource methods (image build/pull, plugin pull/upgrade, service update) assigned `query = encode_query_params(parsed)` but built the request query inline via `parsed.slice(*query_params)`, leaving the local unused. RuboCop flagged Lint/UselessAssignment, failing CI. Remove the dead assignments — no behavior change, the requests already send their query params. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI lint went red after the Stainless migration surfaced normal in-repo CI: RuboCop
Lint/UselessAssignmentforqueryin 5 resource methods.In
image build/image pull,plugin pull/plugin upgradeandservice update, the generated code assignsquery = DockerEngineRuby::Internal::Util.encode_query_params(parsed)but the@client.request(...)call builds its query inline (query: parsed.slice(*query_params)...), so thequerylocal is never read.Removed the 5 dead assignments. No behavior change — those endpoints still send their query params.
./scripts/lint(RuboCop + Sorbet) and./scripts/test(182 runs, 0 failures) are green.🤖 Generated with Claude Code